Skip to content

Small cleanup around generators #4096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 28, 2025
Merged

Small cleanup around generators #4096

merged 1 commit into from
Aug 28, 2025

Conversation

szakarias
Copy link
Contributor

Nits following #4095

sigurdm
sigurdm reviewed Aug 28, 2025
View reviewed changes
Copy link
Contributor

@sigurdm sigurdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we actually have this init method?
Why not just a constructor?

@szakarias szakarias merged commit 53222e2 into dart-lang:main Aug 28, 2025
11 checks passed
@szakarias
Copy link
Contributor Author

Why do we actually have this init method? Why not just a constructor?

Yeah, we could consider just inlining the call...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sigurdm sigurdm sigurdm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@szakarias @sigurdm